Fix a bug when unsub from a non-subscribed parent topic #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/aws-crt-nodejs#405
Description of changes:
The issue happens when the application tries to unsubscribe from a non-subscribed parent topic. As an example:
As the "test/topic" is never subscribed, the topic tree would not delete the topic.
However, topic tree would treat the topic as "deleted" and tries to update the underlying topic filter, which hits the assertion.
Fixed it by validating if the topic is deleted before proceed to next step.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.