Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test for #297 #298

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Unit Test for #297 #298

merged 2 commits into from
Jun 5, 2023

Conversation

xiazhvera
Copy link
Contributor

Issue #, if available:

Description of changes:
Update the unit test to cover the issue fixed in #297

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (b3ac03e) 80.33% compared to head (670f33f) 80.25%.

❗ Current head 670f33f differs from pull request most recent head dfbf8a7. Consider uploading reports for the commit dfbf8a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   80.33%   80.25%   -0.08%     
==========================================
  Files          18       18              
  Lines        7572     7572              
==========================================
- Hits         6083     6077       -6     
- Misses       1489     1495       +6     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bretambrose bretambrose merged commit d3377e4 into main Jun 5, 2023
31 checks passed
@bretambrose bretambrose deleted the unsub_crash_utest branch June 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants