Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dashboard and S3 Benchmark Stack #427

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented May 3, 2024

Description of changes:
Removes dashboard and s3 benchmark stack in favor of https://github.com/awslabs/aws-crt-s3-benchmarks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (f222ada) to head (1e89c44).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   89.53%   89.52%   -0.02%     
==========================================
  Files          20       20              
  Lines        6012     6012              
==========================================
- Hits         5383     5382       -1     
- Misses        629      630       +1     

see 1 file with indirect coverage changes

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

@waahm7 waahm7 merged commit 03341c5 into main May 6, 2024
30 checks passed
@waahm7 waahm7 deleted the remove-s3-benchmark-stack branch May 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants