Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cdk docs" works but prints an error "Unknown command: docs" #256

Closed
eladb opened this issue Jul 9, 2018 · 0 comments · Fixed by #262
Closed

"cdk docs" works but prints an error "Unknown command: docs" #256

eladb opened this issue Jul 9, 2018 · 0 comments · Fixed by #262

Comments

@eladb
Copy link
Contributor

eladb commented Jul 9, 2018

Version: v0.7.3

When running cdk docs, the browser opens with the docs website but an error Unknown command: docs is printed in red.
RomainMuller added a commit that referenced this issue Jul 9, 2018
@RomainMuller
Handle return from yargs command modules
a273f71 
Prevent the application from reaching the code path in `main` when the
command was handled directly by a `commandDir` module. This prevents
the operation from succeeding, while displaying a message such as
*"Unknown command: docs"* (#256).

In order to achieve this, the module decorator sets `argv.result` on
successful execution of the command module's handler; and if
`argv.result` is set, `main` does not get called.

Fixes #256
@RomainMuller RomainMuller mentioned this issue Jul 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle return from yargs command modules aws/aws-cdk
1 participant
@eladb