Cross build fix #227
Cross build fix #227
Conversation
| @@ -26,7 +26,7 @@ def looks_like_code(path): | |||
| return False | |||
|
|
|||
|
|
|||
| def _apply_value(obj, key, new_value, apply_before=True): | |||
| def _apply_value(obj, key, new_value, apply_before=False): | |||
There was a problem hiding this comment.
Note: applying before by default is arguably wrong. we eval config in arch -> host -> target -> compiler -> version order, and we need to apply them in the same order, ex. host sets cmake flag to on, but we want to disable that cmake flag for a certain compiler, then we need to make sure compiler config value comes after host config value (before it was always inserted at the start).
This is just a spot fix and we do need to address how cmake flags are handled in a more generic way
| @@ -550,7 +550,7 @@ class PKG_TOOLS(Enum): | |||
| }, | |||
| 'gcc': { | |||
| 'hosts': ['linux', 'manylinux', 'al2012', 'al2', 'freebsd'], | |||
| 'targets': ['linux', 'freebsd'], | |||
| 'targets': ['linux', 'freebsd', 'android'], | |||
There was a problem hiding this comment.
note: there was a bug in old versions where it would always use default compiler targets to determine whether cross-compile is supported (and default specified all possible targets as supported). that bug was fixed, but data was not updated to indicate that gcc can cross compile to andorid
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.