AWS-LC-FIPS-2.0.14 & MacOS CI Update #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Jul 16, 2024
graebm
reviewed
Jul 17, 2024
.github/workflows/ci.yml
Outdated
| @@ -192,8 +192,8 @@ jobs: | |||
| python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')" | |||
| python builder.pyz build -p ${{ env.PACKAGE_NAME }} downstream | |||
|
|
|||
| osx: # With integration tests | |||
| runs-on: macos-13 # latest | |||
| macos: # With integration tests | |||
There was a problem hiding this comment.
Currently there are 3 macos variants. This is a legacy of when we had to cross-compile arm64. Let's just have 2 variants (arm64 and x64), where they both do integration tests AND that compatibility check
Suggested change
| macos: # With integration tests | |
| macos: |
graebm
approved these changes
Jul 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.