Skip to content

Commit

Permalink
AWS-LC-FIPS-2.0.14 & MacOS CI Update (#808)
Browse files Browse the repository at this point in the history
  • Loading branch information
waahm7 committed Jul 17, 2024
1 parent 37a26c9 commit 5771b28
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 30 deletions.
37 changes: 13 additions & 24 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- 'docs'

env:
BUILDER_VERSION: v0.9.60
BUILDER_VERSION: v0.9.62
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-crt-java
Expand Down Expand Up @@ -192,8 +192,8 @@ jobs:
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
python builder.pyz build -p ${{ env.PACKAGE_NAME }} downstream
osx: # With integration tests
runs-on: macos-13 # latest
macos:
runs-on: macos-14 #latest
steps:
- name: Checkout Sources
uses: actions/checkout@v3
Expand All @@ -204,33 +204,20 @@ jobs:
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
chmod a+x builder
./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream
python3 codebuild/macos_compatibility_check.py
osx-arm64:
runs-on: macos-13 # latest
macos-x64:
runs-on: macos-14-large #latest
steps:
- name: Checkout Sources
uses: actions/checkout@v3
with:
submodules: true
- name: Build ${{ env.PACKAGE_NAME }} + consumers
run: |
mvn -B compile -P mac-arm64
- name: verify backward compatibility
run: |
python3 codebuild/macos_compatibility_check.py armv8
osx-x64:
runs-on: macos-13
steps:
- name: Checkout Sources
uses: actions/checkout@v2
with:
submodules: true
- name: Build ${{ env.PACKAGE_NAME }} + consumers
run: |
mvn -B compile -P mac-x64
- name: verify backward compatibility
run: |
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
chmod a+x builder
./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream
python3 codebuild/macos_compatibility_check.py
android:
Expand Down Expand Up @@ -328,15 +315,17 @@ jobs:
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
python builder.pyz localhost-test -p ${{ env.PACKAGE_NAME }} --spec=downstream
localhost-test-mac:
runs-on: macos-13 # latest
localhost-test-macos:
runs-on: macos-14 # latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
submodules: true
- name: Configure local host
run: |
python3 -m venv .venv
source .venv/bin/activate
python3 -m pip install h2
cd crt/aws-c-http/tests/py_localhost/
python3 server.py &
Expand Down
2 changes: 1 addition & 1 deletion crt/aws-lc
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
<activation>
<os>
<family>mac</family>
<arch>arm64</arch>
<arch>aarch64</arch>
</os>
</activation>
<properties>
Expand Down
1 change: 1 addition & 0 deletions src/native/mqtt5_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,7 @@ JNIEXPORT jlong JNICALL Java_software_amazon_awssdk_crt_mqtt5_Mqtt5Client_mqtt5C

struct aws_socket_options *socket_options = NULL;
struct aws_socket_options tmp_socket_options;
AWS_ZERO_STRUCT(tmp_socket_options);
jobject jni_socket_options =
(*env)->CallObjectMethod(env, jni_options, mqtt5_client_options_properties.options_get_socket_options_id);
if (aws_jni_check_and_clear_exception(env)) {
Expand Down

0 comments on commit 5771b28

Please sign in to comment.