-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PECL release follow up #90
Merged
Merged
Changes from 73 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
e5e998a
require composer to load awscrt extension
TingDaoK 31a5785
load extension before run composer
TingDaoK 82abc2d
make test after the composer nonsense
TingDaoK 1a0efbf
try to just use make test?
TingDaoK 17b6a93
run test
TingDaoK 9ff650e
clean up
TingDaoK 9de07ef
restructure
TingDaoK 826974a
change dir from run test
TingDaoK f6314a2
update the script path from ci
TingDaoK 1f6f814
create release action when we cut a new release
TingDaoK 9de1d33
more fix
TingDaoK f183523
make a github action to test pecl before release
TingDaoK 093cf4e
why not find
TingDaoK b6a3a29
use mac
TingDaoK 08aa34b
skip verification
TingDaoK 3015509
build and test as well
TingDaoK 279f5d2
just make sure it builds
TingDaoK a7e8407
use mac to release
TingDaoK 02a6591
trivial
TingDaoK 7d56d18
oh, it was a typo..
TingDaoK 26ab397
windows CI
TingDaoK 8208b31
get the right directory
TingDaoK 311edc6
why?
TingDaoK 2aae069
this?
TingDaoK 8455b69
why cannot find dll
TingDaoK babc4bf
one more test
TingDaoK 3ad39d5
fine
TingDaoK 72c24d9
generate php-win.ini
TingDaoK 7c12d40
get the right php
TingDaoK a28388f
give me echo
TingDaoK ce4a00c
I don't know
TingDaoK 8c66121
I don't know
TingDaoK e361f03
Windows ci fix (#86)
TingDaoK b116a18
it should not be needed for the config platform
TingDaoK c0ab711
Revert "it should not be needed for the config platform"
TingDaoK c2f584a
remove release.yml and leave it as todo to follow up quick
TingDaoK ff20f95
Rewrite script (#87)
TingDaoK b4d352c
Merge branch 'native-extension-rewrite' of github.com:awslabs/aws-crt…
TingDaoK 77f0fbb
Add .gitattributes to trim down the dist
sunaoka e210901
update gitattributes
TingDaoK 202fd2e
try if it breaks anything
TingDaoK ec1dce0
update README
TingDaoK 91f68d9
update README
TingDaoK a63ac28
try CMD to run multiple lines of code
TingDaoK a9ab031
try to not force the special version of phpunit
TingDaoK 6bc427d
update comments
TingDaoK f9513c2
Merge branch 'native-extension-rewrite' into composer-update-2
TingDaoK c1512f9
address comments
TingDaoK b5fec52
automate the release process
TingDaoK 21b8f00
test
TingDaoK 1226b90
more
TingDaoK 071de01
why git describe doesn't work
TingDaoK e4ae710
test
TingDaoK 7b1909a
using v2?
TingDaoK 232cc72
why?
TingDaoK 12fc7e0
test with this
TingDaoK 508cf9a
bad naming
TingDaoK 1cb0cf2
this?
TingDaoK 8bf63c4
use github output
TingDaoK c41f667
fix?
TingDaoK a9f7c20
remove the "
TingDaoK fc49d94
undo the ci change
TingDaoK c1ffe7d
remove not used script
TingDaoK 00f1598
Merge branch 'main' into auto-release
TingDaoK 1924852
Merge branch 'main' into auto-release
TingDaoK a577841
the `awscrt.stub.php` is part of source
TingDaoK 2dd3fea
ignore ext-awscrt
TingDaoK 9fc2753
another guess
TingDaoK 2abca71
don't delete it
TingDaoK 2af88ee
aha
TingDaoK bb22480
build install?
TingDaoK e6c0d80
make the build cleaner
TingDaoK 8637ff7
looks like working!
TingDaoK 75633f5
maybe sudo?
TingDaoK c9efe03
let the prepare script to update the version
TingDaoK 31f80f4
don't actually need to copy things around?
TingDaoK File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
|
||
name: Release PECL Preparation | ||
|
||
# on: | ||
# release: | ||
# types: [published] | ||
# workflow_dispatch: | ||
|
||
# TO test | ||
on: | ||
push: | ||
branches-ignore: | ||
- 'main' | ||
|
||
jobs: | ||
package: | ||
name: Prepare package | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: '8.0' | ||
|
||
- name: Checkout Source | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
submodules: recursive | ||
|
||
- name: Prepare Package Script | ||
id: prepare-package | ||
# Update the version in code and generate the package. | ||
run: | | ||
version_with_v=$(git describe --tags --abbrev=0) | ||
VERSION=$(echo ${version_with_v} | cut -f2 -dv) | ||
sed -i "s/#define CRT_VERSION .*/#define CRT_VERSION \"$VERSION\"/g" ext/crt.c | ||
echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT | ||
python3 dev-scripts/prepare_pecl_release.py --name aws-crt --user aws-crt --email aws-sdk-common-runtime@amazon.com --version ${VERSION} | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: pecl_package_${{ steps.prepare-package.outputs.VERSION }} | ||
path: awscrt-${{ steps.prepare-package.outputs.VERSION }}.tgz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -179,6 +179,7 @@ fabric.properties | |
.deps | ||
.libs/ | ||
build/ | ||
cmake_build/ | ||
configure.in | ||
configure.ac | ||
configure.bat | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
*.so | ||
api.h | ||
awscrt.stub.php |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -263,6 +263,8 @@ static PHP_GINIT_FUNCTION(awscrt) { | |
awscrt_globals->log_level = 0; | ||
} | ||
|
||
#define CRT_VERSION "0.1.0" | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I recommend you use the normalized PHP_AWSCRT_VERSION macro name, and define it in some header in package root directory, so this version will be checked by pecl during upload See https://github.com/php/web-pecl/blob/master/public_html/release-upload.php#L140 |
||
zend_module_entry awscrt_module_entry = { | ||
STANDARD_MODULE_HEADER, | ||
"awscrt", | ||
|
@@ -272,7 +274,7 @@ zend_module_entry awscrt_module_entry = { | |
NULL, /* RINIT */ | ||
NULL, /* RSHUTDOWN */ | ||
NULL, /* MINFO */ | ||
NO_VERSION_YET, | ||
CRT_VERSION, | ||
PHP_MODULE_GLOBALS(awscrt), | ||
PHP_GINIT(awscrt), | ||
NULL, /* GSHUTDOWN */ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously not the proper version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's not. I was hoping to automate the release process and update this to real version here