-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Subscription tests #540
Conversation
818373f
to
9fe329f
Compare
test/test_mqtt5.py
Outdated
@@ -171,7 +172,6 @@ def test_client_creation_maximum(self): | |||
receive_maximum=1000, | |||
maximum_packet_size=10000, | |||
will_delay_interval_sec=1000, | |||
will=publish_packet, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed? This test is attempting a creation with everything that can possibly be set including the will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add will back to test_client_creation_maximum and ship
Shared Subscription tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.