Always use virtual environments in CI, because PEP 668 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` aws-c-common v0.9.20 -> v0.9.21 aws-lc v1.28.0 -> v1.29.0 s2n v1.4.15 -> v1.4.16 ```
see: awslabs/aws-c-common#1113 remove the `./scripts/format-c.py` script in favor of having the same `./format-check.py -i` script in the same place as every other repo
graebm
added a commit
to awslabs/aws-crt-builder
that referenced
this pull request
Jun 18, 2024
**Issue:** awslabs/aws-crt-python#573 needs python3's `venv` installed on all docker images, due to [PEP 668](https://peps.python.org/pep-0668/). While trying to update our `raspbian-bullseye` image, I discovered it's been broken for months. We'd been [hacking around this](#256) by not even trying to build it anymore, copy/pasting an old working version instead. **Description of changes:** - Install `python3-venv` in Docker images that didn't already have it - Fix `raspbian-bullseye` image. - The old image was getting 404 from some repository while running `apt-get update` - Use different base image: https://github.com/dtcooper/raspberrypi-os-docker. This was the only easily available `bullseye` image I could find. The implementation looks simple, and it's working. - Remove extra stuff from this docker image, like building additional versions of python. I don't know what these were used for (@xiazhvera do you know?). None of our other docker images go through this trouble to build extra python versions. This is already the slowest docker image, due to being armv7, so removing extra work and complication seems extra good.
TingDaoK
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
CI is not working on some newer OSs (Ubuntu 24.04, OpenBSD 7.5) due to PEP 668 which disallows global installations from pip.
Description of changes:
Always run CI in a virtual environment (using path
.venv-builder)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.