Adding SNS To lambda DDK stage and SNS factory #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmolsgandhi
requested review from
kukushking,
malachi-constant and
LeonLuttenberger
Comment on lines
+158
to
+170
| self._function.add_event_source( | ||
| SnsEventSource( | ||
| topic=self._topic, | ||
| dead_letter_queue=SQSFactory.queue( | ||
| self, | ||
| id=f"{id}-dlq", | ||
| environment_id=environment_id, | ||
| ) | ||
| if dead_letter_queue_enabled | ||
| else None, | ||
| filter_policy=filter_policy, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Should we have an SQS queue in between the SNS topic and the Lambda to make the lambda more efficient? Also, have you tested how the redrive logic works with just an SNS queue? Is there an easy way to republish a message from the DLQ into the SNS topic?
There was a problem hiding this comment.
To the first point, I would just opt for writing an sns event into a stage and having it precede our existing SqsToLambda stage. Agreed that we should test redrive..
There was a problem hiding this comment.
I'm going to start converting your code to TS ( #250 ) tomorrow and we can move the convo over there once its drafted.
|
Can we move discussion of this stage over to #252 |
|
Closed and continued in #252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Adding SNS lambda stage and SNS factory
Detail
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.