-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread safety enhancements #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code changes and unit tests for thread-safety
Thread-safety enhancements, unit tests, and benchmarking
paggynie
approved these changes
Aug 23, 2022
giancarlokc
approved these changes
Aug 25, 2022
… into thread-safety
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent PR as #104, but pointing to the master branch.
To track conversation history, check #104.
Issue #, if available: #61
Description of changes: Added thread-safety enhancements, unit tests, and benchmarking code.
The benchmarking code measures the performance of the library under 3 diffrent internal synchronization situations:
The main purposes of the benchmarking are:
Here are the benchmarking results:
![image](https://user-images.githubusercontent.com/71293855/182231710-b3cdb4c2-b0cd-4866-812e-7642c1733917.png)
This proves that adding either lock would not cause an significant extra delay to single-threaded users.a. each thread publishes 1000 metrics
![image](https://user-images.githubusercontent.com/71293855/182232180-f582cd13-20f2-498b-b516-588bb88181fe.png)
b. each thread flushes 100 times![image](https://user-images.githubusercontent.com/71293855/182232339-96d033e3-faa2-4304-af58-b8b1a1e6de0d.png)
These tests indicates that internal sync with a lock increases average ops time on single method, but overall ops time is still fast enough.Each thread executing mixed metheds 100 times:
![image](https://user-images.githubusercontent.com/71293855/182232684-af853ae4-52c7-46dd-a503-1b1fe1c02261.png)
This illustrates the overall performance under different lock situations, especially the performance difference between the two locks.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.