Preserve the metricScope function parameter typing using generics #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
When trying to use the metricScope with function parameters, I noticed that the input arguments were being cast as
any[]
.This is dangerous and can lead to cases where users are able to declare something like this:
but then (accidentally) call it like this which can cause runtime errors:
This PR fixes this by preserving the
args
typing information via using generics and having the generic extendreadonly unknown[]
which is the immutable, type safe way to do this.I updated existing tests to account for this (since some of them, by design, wouldnt compile with this change) as well as updated the
README.md
to be more clear how to use themetricScope
when you want your function to have arguments.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.