Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sdk v3 now that fluent-plugin-s3 also uses it #152

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 28, 2018

removes a ton of dependencies when installing https://rubygems.org/gems/fluent-plugin-s3

@riywo @adammw

⚠️note-to-self do not force-push since we use that commit ⚠️

@grosser grosser force-pushed the grosser/deps branch 4 times, most recently from 3ef3c90 to cc5eabd Compare June 28, 2018 17:35
removes a ton of dependencies when installing
@riywo riywo added this to the v3.0 milestone Aug 23, 2018
@riywo riywo added this to TODO in v3 Aug 23, 2018
@riywo riywo moved this from TODO to Releasing in v3 Aug 23, 2018
@simukappu
Copy link
Contributor

Hi @grosser,
Thank you for your contribution! Now we are discussing that we're going to merge #156 including your #152. Then, we will release these update as v3.0.0-rc (#158).

Before merging your contribution, could you confirm to the formal statement below?:

"Please confirm this contribution is under the terms of the Apache 2.0 license. Thanks."

@grosser
Copy link
Contributor Author

grosser commented Aug 25, 2018

I confirm this contribution is under the terms of the Apache 2.0 license.

@simukappu
Copy link
Contributor

Thank you - @grosser! We will merge this as soon as possible.

@riywo riywo merged commit 17b6d5d into awslabs:master Aug 27, 2018
@riywo riywo moved this from Releasing to Done in v3 Aug 27, 2018
@riywo riywo mentioned this pull request Jan 20, 2019
@simukappu simukappu mentioned this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v3
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants