Remove support for fluentd v0.12 and use new Plugin API #156
Conversation
removes a ton of dependencies when installing
There was a problem hiding this comment.
should view without whitespace :D
https://github.com/awslabs/aws-fluent-plugin-kinesis/pull/156/files?utf8=%E2%9C%93&diff=unified&w=1
|
Hi @adammw, Before merging, could you confirm to the formal statement below?: "Please confirm this contribution is under the terms of the Apache 2.0 license. Thanks." |
|
Hi @adammw - sorry for asking you to confirm that many times. We have discussed adding you to CONTRIBUTORS.txt. We need you to confirm the license before merging. Could you confirm to the formal statement below? "Please confirm this contribution is under the terms of the Apache 2.0 license." Thank you for your strong support! |
|
Please confirm this contribution is under the terms of the Apache 2.0 license. Thanks. |
|
... no you have to say "I confirm" |
|
awks... |
|
I confirm this contribution is under the terms of the Apache 2.0 license. |
|
Thank you - @adammw! We will merge this as soon as possible. |
|
Related to this, would you (awslabs) consider accepting a pull request for the v2 branch which switches to only pulling the v3 aws sdk components needed, instead of depending on |
|
Just for clarification, I'm asking because the 8-10 minutes it takes to install all of the |
Fixes #155 and includes #152
There's a lot of code in this plugin to support the previous version of the fluentd plugin API. fluentd 0.14 has been out for two years now, hopefully most people can/have upgraded, and the cruft can be removed as a new major version of the plugin.
/cc @riywo