-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Avoid error from null value for observer in timeoutStartSubscriptionAck function #595
Fix: Avoid error from null value for observer in timeoutStartSubscriptionAck function #595
Conversation
Please pull this in! |
There have been multiple issues opened related to this, can we get this merged, please? |
Can we please merge this? |
Can this pull request get merged please? Subscriptions are unstable and it causes app to crash due to this issue. |
This issue also exists in the timeoutDIsconnect function too!
Would be good if we could cover both issues? |
There hasn't been any traction on this for some time, so, we tried this workaround and it seems to be working. Adding it here so that others can give it a shot as well - https://dev.to/willsamu/how-to-get-aws-appsync-running-with-offline-support-and-react-hooks-678 |
Hey @jcbdev . I opened this to fix the issue in the timeoutDisconnect function. Thanks for the suggestion. @sammartinez @elorzafe Hey guys. This PR has been open for a while, can we please get it merged? |
@elorzafe are you still monitoring this? the best Holiday gift you could give us all would be merging this PR! 🎄🎅 |
What's the hold up with this? Can someone from AWS explain? |
@sammartinez Hi, have I missed a step in opening this PR? I read and followed the contributing guidelines. Maybe I missed something. Kindly give feedback on the next steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KvNGCzA thanks for this PR.
I am sorry for the delay. We will do a release of this ASAP
@elorzafe Thank you for your response. Cheers. |
Issue #, if available:
#515 #544 #596
Description of changes:
An if statement to make sure that the
observer
exists before it tries to call the properties ofobserver
in timeoutStartSubscriptionAck functionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.