Fix: Avoid error from null value for observer in timeoutDisconnect function #609
Conversation
|
Anything holding this PR back? I have been seeing this error lot of times and getting picked by crashlytics. we should merge this sooon |
|
@elorzafe please check this out for review |
|
@elorzafe Thank you. This PR exists for a similar issue. Please spare a few minutes to check it out |
| if (!observer) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
@KvNGCzA I think this should never happen. If the map is empty, the callback wouldnt been call? Did you experience something that the observer is undefined. I think the issue is somewhere else. I will keep looking
There was a problem hiding this comment.
@elorzafe After a subscription is established, I randomly get the following error(s): Undefined is not an object evaluating (_a.observer) or Cannot read property 'observer' of undefined
These errors appear randomly in my case. I'm suspecting it has to do with something with the subscription timing out.
There was a problem hiding this comment.
I was able to reproduce this error by randomly switching between networks(WiFi/4G). I have already rollout a build with this patch and I am no longer getting this crash. Thank you
|
@KvNGCzA @gprasadholla we just published the first fix, next week I will continue working on the other issues and doing a following release. |
|
This was addressed by #616 |
Issue #, if available:
#515 #544 #596
Description of changes:
An if statement to make sure that the
observerexists before it tries to call the properties ofobserverin timeoutDisconnect function.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.