Fixed issues when using with Angular #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
approved these changes
Sep 8, 2022
|
could this please be merged? could not get around the build errors for a react app.. :( |
|
What is the status of this? I hate to be that guy, but I'm going to be honest... The length of time these issues were open without resolution, and that this pull request has taken a month and a half makes me feel like this AWS Lab project is in the territory of abandonware.... |
|
@david-mcafee @dpilch any status update on getting this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #713, #566, #727, #709
Description of changes:
Wasn't building in Angular projects. Used a fix from #566 that was never merged to fix "Unknown is not assignable" error. This was originally rejected in #727 as unnecessary if you include your Apollo components from "@apollo/client", however this is not a valid solution. Apollo/client has a dependency on React, whereas Apollo/client/core does not. See the following thread: apollographql/apollo-client#7318
Fixed issues surrounding with ZenObservable.
The current release of "@Apollo/client" was including an un-released version of 1.2.5, whereas npm install was grabbing the current release of 1.1.0. These are incompatible. I had included 1.2.5 in my Angular project to resolve that. This PR moves that dependency into the package's package.json.
ZenObservable still wasn't found, so I implemented the fix from Gerhardavon in #709, however the syntax had to change slightly to work.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.