Remove unpublished runtime crates from versions table #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
approved these changes
Apr 17, 2023
ysaito1001
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Apr 17, 2023
## Motivation and Context The `aws-smithy-runtime-test` crate has repeatedly caused an issue each time we released `aws-sdk-rust` from the `smithy-rs-release-0.55.x` branch. Example PRs for fixing the issue in `aws-sdk-rust` include - awslabs/aws-sdk-rust#778 - awslabs/aws-sdk-rust#787 - awslabs/aws-sdk-rust#789 This PR will remove the crate in question from the release branch so that next time we release from `smithy-rs-release-0.55.x`, we do not need to deal with what's listed above. The issue only occurs in the `smithy-rs-release-0.55.x` branch, and the main branch, as of this writing, no longer has it because the crate has moved from `aws/sdk/integration-tests` to `aws/sra-test`. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Yuki Saito <awsaito@amazon.com>
aws-sdk-rust-ci
pushed a commit
that referenced
this pull request
May 1, 2023
## Motivation and Context The `aws-smithy-runtime-test` crate has repeatedly caused an issue each time we released `aws-sdk-rust` from the `smithy-rs-release-0.55.x` branch. Example PRs for fixing the issue in `aws-sdk-rust` include - #778 - #787 - #789 This PR will remove the crate in question from the release branch so that next time we release from `smithy-rs-release-0.55.x`, we do not need to deal with what's listed above. The issue only occurs in the `smithy-rs-release-0.55.x` branch, and the main branch, as of this writing, no longer has it because the crate has moved from `aws/sdk/integration-tests` to `aws/sra-test`. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Yuki Saito <awsaito@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR will keep crate versions table in
CHANGELOG.mdin sync with #768 and #787.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.