Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset attributes screen name and screen unique id #32

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add _screen_name and _screen_unique_id as preset attributes

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 12, 2023
@zxkane zxkane merged commit 0786eef into main Sep 13, 2023
5 checks passed
@zxkane zxkane deleted the feature_preset_attribute branch September 13, 2023 07:54
zhu-xiaowei added a commit that referenced this pull request Oct 19, 2023
Co-authored-by: xiaoweii <xiaoweii@amazom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants