Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hash code to request query parameter #35

Merged
merged 5 commits into from
Sep 20, 2023
Merged

feat: add hash code to request query parameter #35

merged 5 commits into from
Sep 20, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Sep 18, 2023

Description

  1. remove hash code in event attribute
  2. add hash code in request query parameter

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 18, 2023
@zhu-xiaowei zhu-xiaowei marked this pull request as draft September 19, 2023 03:41
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review September 19, 2023 10:18
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (b20086b) 95.23% compared to head (d343ee0) 95.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   95.23%   95.17%   -0.07%     
==========================================
  Files          34       34              
  Lines        1763     1761       -2     
==========================================
- Hits         1679     1676       -3     
- Misses         84       85       +1     
Files Changed Coverage Δ
...ependency/Clickstream/Event/ClickstreamEvent.swift 97.84% <ø> (-0.07%) ⬇️
Sources/Clickstream/Network/NetRequest.swift 78.00% <100.00%> (-1.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 459f25b into main Sep 20, 2023
5 checks passed
@zxkane zxkane deleted the hash_code branch September 20, 2023 04:13
zhu-xiaowei added a commit that referenced this pull request Oct 19, 2023
Co-authored-by: xiaoweii <xiaoweii@amazom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants