Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build #116

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix broken build #116

merged 1 commit into from
Feb 6, 2020

Conversation

felixbiessmann
Copy link
Contributor

*Issue #115 *

Description of changes:

  • fixed dependencies in requirements.txt
  • changed pandas usage to latest API version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- fixed dependencies in requirements.txt
- changed pandas usage to latest API version
Copy link
Contributor

@tdhd tdhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix! Did you find out what was causing the builds to fail?

@felixbiessmann
Copy link
Contributor Author

Thanks Felix! Did you find out what was causing the builds to fail?

This backwards incompatible API change in pandas in the latest pandas version 1.0.0 released on Jan 29 appears to have broken the subsequent builds.

I couldn't reproduce the file permission errors locally, but with the pandas dependency set to pre 1.0.0 the travis build was working again.

The code that raised the error should now also be compatible with the latest pandas version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants