-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable column profile histogram analysis for columns of numeric types #97
Enable column profile histogram analysis for columns of numeric types #97
Conversation
… float, integer, long, and short
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Paul,
The PR looks really good, I only have a few "cosmetic" requests :)
src/test/scala/com/amazon/deequ/profiles/ColumnProfilerTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/amazon/deequ/profiles/ColumnProfilerTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/amazon/deequ/profiles/ColumnProfilerTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/amazon/deequ/profiles/ColumnProfilerTest.scala
Outdated
Show resolved
Hide resolved
I checked our coding style https://github.com/databricks/scala-style-guide#indent and you are right that we dont need to indent long method invocations with 4 spaces, sorry for that. I deleted the corresponding comments. |
@sscdotopen Ok, I made those changes |
@sscdotopen can you re-review this pr? |
Looks good, thank you! |
Fix for issue: #95
Description of changes:
Histogram analysis for column profiling was limited to boolean and string columns. However, it is possible to have categorical data with numerical values (ex 1 indicating male and 2 indicating female). Made changes to allow histogram analysis for columns with short, long, double, float, and integer data types
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.