This repository has been archived by the owner on May 6, 2024. It is now read-only.
Pass task definition volumes to support EFS #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaskis
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #30 but this is just a quick fix, not full support for volumes
Description of changes:
With the release of EFS support in Fargate I tried to deploy to a service with a mounted volume. But I got the error that the volume name didn't exist and after running with
--verboseI noticed it just wasn't sent along with the task definition.This PR passes through the volumes part of the task definition so that
fargate service deploystill works when a task has volumes.It also updates the AWS SDK because the previous version did not support the EFS configuration of volumes in task definitions so the information was lost in updates.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.