File input #24
Closed
File input #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, that the CI is failing on FreeBSD, because of inotify, which is a Linux kernel feature. Looks it can be tricky to support Linux and FreeBSD. |
|
Errr.. yes, don't break portability please... |
|
Maybe use https://github.com/passcod/notify ? |
|
This passcod/notify looks promising! |
|
There is some problem with passcod/notify also. I created a issue there notify-rs/notify#155. I would say this PR is put on hold, till notify v5 is released. |
|
@Trojan295 |
|
I'll try to look at this today. |
Trojan295
force-pushed
the
file-input
branch
2 times, most recently
from
a1c54c7
to
f91f52a
Compare
Trojan295
force-pushed
the
file-input
branch
from
f91f52a
to
bccf8c0
Compare
|
Ok, CI is green, so I believe it can be reviewed. @jedisct1 |
crisidev
added a commit
to amazon-archives/flowgger-hold
that referenced
this pull request
Jul 19, 2019
Merge PR awslabs#24 from upstream (#4)
|
We merged this PR with small changes during the transition to awslabs. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
The file input: