Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update jsii to 5.1 #182

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: update jsii to 5.1 #182

merged 1 commit into from
Jan 10, 2024

Conversation

scottschreckengaust
Copy link
Collaborator

JSII 5.0 is being deprecated

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!                                                                                                     !!
!!  The 5.0 release line of jsii will reach End-of-Support soon, on 2024-01-31T00:00:00.000Z.          !!
!!  We strongly recommend you upgrade to the current release line (5.3) at your earliest convenience.  !!
!!                                                                                                     !!
!!  Other actively supported release lines include:                                                    !!
!!  - 5.1 (planned End-of-Support date: 2024-02-28T00:00:00.000Z)                                      !!
!!  - 5.2 (planned End-of-Support date: 2024-06-30T00:00:00.000Z)                                      !!
!!                                                                                                     !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@scottschreckengaust
fix: update jsii to 5.1
f32d476 
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@scottschreckengaust scottschreckengaust requested a review from a team as a code owner January 9, 2024 23:23
@krokoko krokoko enabled auto-merge (rebase) January 9, 2024 23:30
@krokoko
Copy link
Collaborator

krokoko commented Jan 9, 2024

Looks good, projen is using the version 5.1.X as well

https://github.com/projen/projen/blob/c86bb9a1fd2794b0385d5b9da333fe273a4fd535/package.json#L70

@krokoko krokoko closed this Jan 9, 2024
auto-merge was automatically disabled January 9, 2024 23:31

Pull request was closed

@krokoko krokoko reopened this Jan 9, 2024
@krokoko
Copy link
Collaborator

krokoko commented Jan 9, 2024

sorry closed by mistake...

@krokoko krokoko enabled auto-merge (rebase) January 9, 2024 23:31
@krokoko krokoko merged commit 9b1265b into main Jan 10, 2024
30 of 31 checks passed
@krokoko krokoko deleted the fix/jsii-5.0-deprection branch January 10, 2024 00:49
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krokoko krokoko krokoko approved these changes

@MichaelWalker-git MichaelWalker-git MichaelWalker-git approved these changes

@hvital hvital Awaiting requested review from hvital hvital is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@laithalsaadoon laithalsaadoon Awaiting requested review from laithalsaadoon laithalsaadoon is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@dineshSajwan dineshSajwan Awaiting requested review from dineshSajwan dineshSajwan is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

Assignees
No one assigned
Labels
admired-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottschreckengaust @krokoko @MichaelWalker-git @emerging-tech-cdk-constructs-bot