fix(lambda layer): fix wrong path preventing deployment #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokoko
requested review from
hvital,
laithalsaadoon,
MichaelWalker-git and
dineshSajwan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 94.97% 94.95% -0.03%
==========================================
Files 31 33 +2
Lines 7804 8005 +201
Branches 215 221 +6
==========================================
+ Hits 7412 7601 +189
- Misses 392 404 +12 ☔ View full report in Codecov by Sentry. |
hvital
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Lambda Layer construct (regression) where the path to the asset is wrong, preventing correct deployment
Tested manually in Typescript and Python to make sure it synths correctly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.