Skip to content

Commit

Permalink
fix: requestBuffer (#49)
Browse files Browse the repository at this point in the history
* Fix requestBuffer
* Remove legacy sitewise data source
* Remove fetchAgggreagtedData boolean from settings
* Fix requests to only be made for uncached data
* Fix gesture tests

Co-authored-by: Norbert Nader <nnader@amazon.com>
  • Loading branch information
NorbertNader and NorbertNader committed Feb 11, 2022
1 parent dd24732 commit 4702ad5
Show file tree
Hide file tree
Showing 19 changed files with 683 additions and 305 deletions.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ describe('handles gestures', () => {

cy.wait(SECOND_IN_MS * 2);

cy.matchImageSnapshot('zooms in', snapshotOptions);
cy.get(testChartContainerClassNameSelector).dblclick();

cy.wait(SECOND_IN_MS * 2);

cy.matchImageSnapshot('zooms in', snapshotOptions);

cy.get(testChartContainerClassNameSelector).dblclick({ shiftKey: true });

cy.wait(SECOND_IN_MS * 2);
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/testing/renderChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const defaultSettings = {
resolution: {
[3 * MINUTE_IN_MS]: '1m',
},
fetchAggregatedData: true,
};

const start = new Date(2022, 0, 0, 0, 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ export const AGGREGATED_DATA_QUERY = {
{
assetId: AGGREGATED_DATA_ASSET,
properties: [
{ propertyId: AGGREGATED_DATA_PROPERTY },
{ propertyId: AGGREGATED_DATA_PROPERTY_2, resolution: '1m' },
{ propertyId: AGGREGATED_DATA_PROPERTY, resolution: '0' },
{ propertyId: AGGREGATED_DATA_PROPERTY_2 },
],
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export class TestingGround {
request: {
settings: {
resolution: this.resolution,
requestBuffer: 1,
},
viewport: this.viewport,
},
Expand Down

0 comments on commit 4702ad5

Please sign in to comment.