fix: add signigicant digits to xy plot

awslabs · Jan 31, 2024 · 70a109e · 70a109e
1 parent f5eed70
commit 70a109e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/dashboard/src/customization/propertiesSections/settings/index.tsx b/packages/dashboard/src/customization/propertiesSections/settings/index.tsx
@@ -10,8 +10,7 @@ import { PropertyLens } from '~/customization/propertiesSection';
 
 const isSettingsWidget = (
   w: DashboardWidget
-): w is DashboardWidget<CommonChartProperties> =>
-  'queryConfig' in w.properties && w.type !== 'xy-plot';
+): w is DashboardWidget<CommonChartProperties> => 'queryConfig' in w.properties;
 
 const RenderSettingsConfiguration = ({
   useProperty,

diff --git a/packages/react-components/src/components/chart/chartOptions/axes/yAxis.ts b/packages/react-components/src/components/chart/chartOptions/axes/yAxis.ts
@@ -1,9 +1,11 @@
 import { YAXisComponentOption } from 'echarts';
 import { ChartAxisOptions } from '../../types';
 import { DEFAULT_Y_AXIS } from '../../eChartsConstants';
+import { round } from '@iot-app-kit/core-util';
 
 export const convertYAxis = (
-  axis: ChartAxisOptions | undefined
+  axis?: ChartAxisOptions,
+  significantDigits?: number
 ): YAXisComponentOption => ({
   ...DEFAULT_Y_AXIS,
   name: axis?.yLabel,
@@ -15,6 +17,7 @@ export const convertYAxis = (
   axisLabel: {
     hideOverlap: true,
     color: '#5f6b7a',
+    formatter: (value: number) => `${round(value, significantDigits)}`,
   },
   nameLocation: 'middle',
   nameGap: 30,

diff --git a/...eact-components/src/components/chart/chartOptions/seriesAndYAxis/convertSeriesAndYAxis.ts b/...eact-components/src/components/chart/chartOptions/seriesAndYAxis/convertSeriesAndYAxis.ts
@@ -247,7 +247,9 @@ export const useSeriesAndYAxis = (
     useHighlightedDataStreams();
 
   return useMemo(() => {
-    const defaultYAxis: YAXisComponentOption[] = [convertChartYAxis(axis)];
+    const defaultYAxis: YAXisComponentOption[] = [
+      convertChartYAxis(axis, significantDigits),
+    ];
     const convertedThresholds = convertThresholds(thresholds);
 
     const shouldUseEmphasis = highlightedDataStreams.length > 0;