fix(composer): fix adding tag always attached to root (#281)

awslabs · Oct 18, 2022 · 775446a · 775446a
1 parent ecbedc0
commit 775446a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/scene-composer/src/components/toolbars/floatingToolbar/items/AddObjectMenu.tsx b/packages/scene-composer/src/components/toolbars/floatingToolbar/items/AddObjectMenu.tsx
@@ -79,7 +79,7 @@ export const AddObjectMenu = () => {
 
   const selectedSceneNode = useMemo(() => {
     return getSceneNodeByRef(selectedSceneNodeRef);
-  }, [selectedSceneNodeRef]);
+  }, [getSceneNodeByRef, selectedSceneNodeRef]);
 
   const sceneContainsEnvironmentModel = useMemo(() => {
     return (
@@ -135,7 +135,7 @@ export const AddObjectMenu = () => {
 
   const getRefForParenting = useCallback(() => {
     return !isEnvironmentNode(selectedSceneNode) ? selectedSceneNodeRef : undefined;
-  }, [getSceneNodeByRef, selectedSceneNodeRef, selectedSceneNode]);
+  }, [selectedSceneNodeRef, selectedSceneNode]);
 
   const handleAddAnchor = useCallback(() => {
     const anchorComponent: IAnchorComponent = {
@@ -151,7 +151,7 @@ export const AddObjectMenu = () => {
     } else {
       appendSceneNode(node);
     }
-  }, [enhancedEditingEnabled]);
+  }, [enhancedEditingEnabled, getRefForParenting, appendSceneNode, setAddingWidget]);
 
   const handleAddColorOverlay = () => {
     // Requires a selected scene node