fix: propertyName with multi hyphen not working (#496)

awslabs · Jan 23, 2023 · 7c7dc2c · 7c7dc2c
1 parent 371a2dd
commit 7c7dc2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/scene-composer/src/utils/dataBindingUtils.ts b/packages/scene-composer/src/utils/dataBindingUtils.ts
@@ -115,7 +115,7 @@ export const dataBindingValuesProvider = (
  * Currently, the jexl in TwinMaker can't handle "-", while the TwinMaker property can accept "-". This function will escape the special character
  */
 const escapeRestrictedKeys = (value: Record<string, unknown>): [Record<string, string>, Record<string, unknown>] => {
-  const restrictedCharRegex = /-/;
+  const restrictedCharRegex = /-/g;
   const escapedKeyMap: Record<string, string> = {};
   const escapedValues: Record<string, unknown> = {};
 

diff --git a/packages/scene-composer/tests/utils/dataBindingUtils.spec.ts b/packages/scene-composer/tests/utils/dataBindingUtils.spec.ts
@@ -276,7 +276,7 @@ describe('ruleEvaluator', () => {
   });
 
   it('should property names with special characters should work correctly', async () => {
-    const key1 = 'my-temperature';
+    const key1 = 'my-temperature-prop';
     const key2 = 'myRPM';
     const value = {
       [key1]: 22,