fix(react-components, videoPlayer): fix propertiesNotChanged for vide…

…oPlayer
awslabs · Oct 6, 2022 · 9a360b1 · 9a360b1
1 parent eb02085
commit 9a360b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/react-components/src/video-player/videoPlayer.spec.tsx b/packages/react-components/src/video-player/videoPlayer.spec.tsx
@@ -72,8 +72,7 @@ it('should not update session URL when fields are the same for on demand mode',
   expect(getKvsStreamSrcFn).toBeCalledWith(PLAYBACKMODE_ON_DEMAND, startTime, endTime);
 });
 
-// TODO: Fix the flaky test
-it.skip('should not update session URL when fields are the same for live mode', async () => {
+it('should not update session URL when fields are the same for live mode', async () => {
   const getKvsStreamSrcFn = jest.spyOn(mockVideoData, 'getKvsStreamSrc').mockResolvedValue(mockLiveURL);
   const { rerender } = render(<VideoPlayer viewport={{ duration: '0' }} videoData={mockVideoData} />);
 

diff --git a/packages/react-components/src/video-player/videoPlayer.tsx b/packages/react-components/src/video-player/videoPlayer.tsx
@@ -428,10 +428,13 @@ export class VideoPlayer extends React.Component<IVideoPlayerProps, IVideoPlayer
   };
 
   private propertiesNotChanged = (prevProps: IVideoPlayerProps, prevStates: IVideoPlayerState) => {
+    const currentTime = new Date();
     return (
       this.props.videoData === prevProps.videoData &&
-      viewportStartDate(this.props.viewport).getTime() === viewportStartDate(prevProps.viewport).getTime() &&
-      viewportEndDate(this.props.viewport).getTime() === viewportEndDate(prevProps.viewport).getTime() &&
+      viewportStartDate(this.props.viewport, currentTime).getTime() ===
+        viewportStartDate(prevProps.viewport, currentTime).getTime() &&
+      viewportEndDate(this.props.viewport, currentTime).getTime() ===
+        viewportEndDate(prevProps.viewport, currentTime).getTime() &&
       'duration' in this.props.viewport === 'duration' in prevProps.viewport &&
       this.state.playbackMode === prevStates.playbackMode
     );