fix(scene composer): fix for broken rule panel

awslabs · Aug 17, 2023 · c5e071d · c5e071d
1 parent 5e84d15
commit c5e071d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/.../panels/scene-rule-components/__tests__/__snapshots__/SceneRuleTargetEditor.spec.tsx.snap b/.../panels/scene-rule-components/__tests__/__snapshots__/SceneRuleTargetEditor.spec.tsx.snap
@@ -8,7 +8,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"}"
     />
@@ -25,7 +25,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"}"
     />
@@ -42,7 +42,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"}"
     />
@@ -58,7 +58,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"}"
     />
@@ -75,7 +75,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"}"
     />
@@ -92,7 +92,7 @@ exports[`SceneRuleTargetEditor should render a drop down with appropriate option
   >
     <div
       data-mocked="Select"
-      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Animation\\"}]"
+      options="[{\\"label\\":\\"test message\\",\\"value\\":\\"Icon\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Color\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Number\\"},{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"}]"
       selectedarialabel="test message"
       selectedoption="{\\"label\\":\\"test message\\",\\"value\\":\\"Opacity\\"}"
     />

diff --git a/packages/scene-composer/src/interfaces/interfaces.tsx b/packages/scene-composer/src/interfaces/interfaces.tsx
@@ -107,7 +107,6 @@ export const IotTwinMakerIconNamespace = `${IotTwinMakerNamespace}.icon`;
 export const IotTwinMakerColorNamespace = `${IotTwinMakerNamespace}.color`;
 export const IotTwinMakerNumberNamespace = `${IotTwinMakerNamespace}.number`;
 export const IotTwinMakerOpacityNamespace = `${IotTwinMakerNamespace}.opacity`;
-export const IotTwinMakerAnimationNamespace = `${IotTwinMakerNamespace}.animation`;
 /************************************************
  * Scene Resource
  ************************************************/
@@ -117,7 +116,6 @@ export enum SceneResourceType {
   Color = 'Color',
   Number = 'Number',
   Opacity = 'Opacity',
-  Animation = 'Animation',
 }
 
 export interface SceneResourceInfo {

diff --git a/packages/scene-composer/src/utils/sceneResourceUtils.ts b/packages/scene-composer/src/utils/sceneResourceUtils.ts
@@ -36,8 +36,6 @@ export const getSceneResourceDefaultValue = (type: SceneResourceType): string =>
       return IotTwinMakerNumberNamespace;
     case SceneResourceType.Opacity:
       return '1';
-    case SceneResourceType.Animation:
-      return '';
   }
 };