Skip to content

Commit

Permalink
fix(composer): fix show svg (#279)
Browse files Browse the repository at this point in the history
  • Loading branch information
@sheilaXu
sheilaXu committed Oct 14, 2022
1 parent 0d2e427 commit cb6094e
Show file tree
Hide file tree
Showing 8 changed files with 104 additions and 105 deletions.
6 changes: 3 additions & 3 deletions packages/scene-composer/src/assets/auto-gen/icons/Show.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ import { SVGProps } from 'react';

const SvgShow = (props: SVGProps<SVGSVGElement>) => (
<svg width={16} height={14} viewBox='0 0 16 16' fill='none' xmlns='http://www.w3.org/2000/svg' {...props}>
<g clipPath='url(#show_svg__a)' fill='#879596'>
<g clipPath='url(#show_svg__a)' fill='currentColor'>
<path
className='show_svg__center-dot'
d='M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z'
stroke='#879596'
stroke='currentColor'
strokeMiterlimit={10}
/>
<path d='M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z' />
</g>
<defs>
<clipPath id='show_svg__a'>
<path fill='#fff' transform='translate(0 2)' d='M0 0h16v9.78H0z' />
<path fill='currentColor' transform='translate(0 2)' d='M0 0h16v9.78H0z' />
</clipPath>
</defs>
</svg>
Expand Down
8 changes: 0 additions & 8 deletions packages/scene-composer/src/assets/auto-gen/icons/Unchecked.tsx
View file

This file was deleted.

1 change: 0 additions & 1 deletion packages/scene-composer/src/assets/auto-gen/icons/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ export { default as Orbit } from './Orbit';
export { default as Pan } from './Pan';
export { default as Show } from './Show';
export { default as Tag } from './Tag';
export { default as Unchecked } from './Unchecked';
export { default as Unlock } from './Unlock';
6 changes: 3 additions & 3 deletions packages/scene-composer/src/assets/icons/show.svg
View file
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 0 additions & 2 deletions packages/scene-composer/src/assets/icons/unchecked.svg
View file

This file was deleted.

6 changes: 5 additions & 1 deletion packages/scene-composer/src/components/VisibilityToggle/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ const VisibilityToggle: FC<VisibilityToggleProps> = ({ visible = true, onToggle
onClick={onToggleHandler}
variant={'inline-icon'}
className={`tm-visibility-toggle ${visible ? 'visible' : ''} tm-icon-button`.trim()}
iconSvg={<Show />}
iconSvg={
<span>
<Show />
</span>
}
/>
);
};
Expand Down
120 changes: 62 additions & 58 deletions ...omponents/SceneHierarchyTree/__tests__/__snapshots__/SceneHierarchyTreeItem.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,39 +33,41 @@ exports[`SceneHierarchyTreeItem should bubble up when expanded 1`] = `
variant="inline-icon"
>
<div>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
clip-path="url(#show_svg__a)"
fill="#879596"
<span>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="#879596"
stroke-miterlimit="10"
/>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</g>
<defs>
<clippath
id="show_svg__a"
<g
clip-path="url(#show_svg__a)"
fill="currentColor"
>
<path
d="M0 0h16v9.78H0z"
fill="#fff"
transform="translate(0 2)"
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="currentColor"
stroke-miterlimit="10"
/>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</clippath>
</defs>
</svg>
</g>
<defs>
<clippath
id="show_svg__a"
>
<path
d="M0 0h16v9.78H0z"
fill="currentColor"
transform="translate(0 2)"
/>
</clippath>
</defs>
</svg>
</span>
</div>
</div>
</span>
Expand Down Expand Up @@ -149,39 +151,41 @@ exports[`SceneHierarchyTreeItem should render SubModelTree when item has a model
variant="inline-icon"
>
<div>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
clip-path="url(#show_svg__a)"
fill="#879596"
<span>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="#879596"
stroke-miterlimit="10"
/>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</g>
<defs>
<clippath
id="show_svg__a"
<g
clip-path="url(#show_svg__a)"
fill="currentColor"
>
<path
d="M0 0h16v9.78H0z"
fill="#fff"
transform="translate(0 2)"
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="currentColor"
stroke-miterlimit="10"
/>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</clippath>
</defs>
</svg>
</g>
<defs>
<clippath
id="show_svg__a"
>
<path
d="M0 0h16v9.78H0z"
fill="currentColor"
transform="translate(0 2)"
/>
</clippath>
</defs>
</svg>
</span>
</div>
</div>
</span>
Expand Down
60 changes: 31 additions & 29 deletions ...Panel/components/SubModelTree/__tests__/__snapshots__/SubModelTreeItemLabel.spec.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,39 +21,41 @@ exports[`SubModelTreeItemLabel should render as appropriate 1`] = `
variant="inline-icon"
>
<div>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
clip-path="url(#show_svg__a)"
fill="#879596"
<span>
<svg
fill="none"
height="14"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="#879596"
stroke-miterlimit="10"
/>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</g>
<defs>
<clippath
id="show_svg__a"
<g
clip-path="url(#show_svg__a)"
fill="currentColor"
>
<path
d="M0 0h16v9.78H0z"
fill="#fff"
transform="translate(0 2)"
class="show_svg__center-dot"
d="M8 8.89a2 2 0 1 0 0-4 2 2 0 0 0 0 4Z"
stroke="currentColor"
stroke-miterlimit="10"
/>
</clippath>
</defs>
</svg>
<path
d="M7.85 3c2.27 0 4.57 1.31 6.85 3.9-1.07 1.22-3.77 3.88-7 3.88-2.25 0-4.42-1.31-6.46-3.9C2.16 5.69 4.61 3 7.85 3Zm0-1C3.11 2 0 6.89 0 6.89c2.67 3.67 5.33 4.89 7.7 4.89 4.74 0 8.3-4.89 8.3-4.89C13 3.22 10.22 2 7.85 2Z"
/>
</g>
<defs>
<clippath
id="show_svg__a"
>
<path
d="M0 0h16v9.78H0z"
fill="currentColor"
transform="translate(0 2)"
/>
</clippath>
</defs>
</svg>
</span>
</div>
</div>
</span>
Expand Down

0 comments on commit cb6094e

Please sign in to comment.