Skip to content

Commit

Permalink
feat: Add proposed API changes within types declarations (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
diehbria committed Jan 20, 2022
1 parent 82479eb commit d165299
Show file tree
Hide file tree
Showing 9 changed files with 37 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -21,6 +22,8 @@ export class IotBarChart {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/iot-kpi/iot-kpi.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 };

Expand All @@ -21,6 +22,8 @@ export class IotKpi {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -21,6 +22,8 @@ export class IotLineChart {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -21,6 +22,8 @@ export class IotScatterChart {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -21,6 +22,8 @@ export class IotStatusGrid {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -21,6 +22,8 @@ export class IotStatusTimeline {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/iot-table/iot-table.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component, Prop, h } from '@stencil/core';
import { MinimalViewPortConfig } from '@synchro-charts/core';
import { AnyDataStreamQuery, DataModule, TimeSeriesDataRequestSettings } from '@iot-app-kit/core';
import { StyleSettingsMap } from '../types';

const DEFAULT_VIEWPORT = { duration: 10 * 1000 * 60 };

Expand All @@ -19,6 +20,8 @@ export class IotTable {

@Prop() settings: TimeSeriesDataRequestSettings | undefined;

@Prop() styles: StyleSettingsMap | undefined;

getSettings(): TimeSeriesDataRequestSettings {
return {
...this.settings,
Expand Down
8 changes: 8 additions & 0 deletions packages/components/src/components/types.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export type StyleSettings = {
name?: string;
detailedName?: string;
color?: string; // CSS color string, i.e. 'red' or '#ffffff'
unit?: string;
};

export type StyleSettingsMap = { [refId: string]: StyleSettings };
9 changes: 8 additions & 1 deletion packages/core/src/data-sources/site-wise/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ export type AssetId = string;

export type PropertyAlias = string;

// Reference which can be used to associate styles to the associated results from a query
export type RefId = string;

export type PropertyQuery = {
propertyId: string;
refId?: RefId;
resolution?: string;
};

Expand All @@ -26,7 +30,10 @@ type SiteWiseAssetDataStreamQuery = DataStreamQuery & {

// TODO: Make the data stream query support property aliases for unmodeled data support
type SiteWisePropertyAliasDataStreamQuery = DataStreamQuery & {
propertyAliases: PropertyAlias[];
propertyAliases: {
propertyAlias: PropertyAlias;
refId: RefId;
};
};

// Unused currently, this is what we want to work towards.
Expand Down

0 comments on commit d165299

Please sign in to comment.