Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY-plot] y axis label collides with y-axis #2471

Closed
1 task
diehbria opened this issue Jan 10, 2024 · 3 comments
Closed
1 task

[XY-plot] y axis label collides with y-axis #2471

diehbria opened this issue Jan 10, 2024 · 3 comments
Labels
1 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint

Comments

@diehbria
Copy link
Contributor

with y axis with large values, the label can collide with the y-axis
Screenshot 2024-01-10 at 1 46 38 PM

Acceptance criteria

@diehbria diehbria added bug Something isn't working Assigned to HM Work that is being assisted on by HM Current sprint 1 pts labels Jan 10, 2024
@gmuralidharreddy
Copy link
Collaborator

@nadeswal @diehbria for the quick fix, if I increase a bit more(30 to 40) nameGap option to the eCharts axisLabel then it looks like the below screenshots, but if we have a 6digit yAxis values then again we can see the issue.
To fix this issue maybe we need to provide a dynamic left-side spacing based on the yMin yMax values. Let me know if the below solution not looks good then we can start workaround on the dynamic spacing.

Right Legend:
Screenshot 2024-01-19 at 12 30 01 PM

Left Legend:
Screenshot 2024-01-19 at 12 32 23 PM

@diehbria
Copy link
Contributor Author

@gmuralidharreddy it must be dynamic, is there a way to actually just place it to the left of the echarts canvas, rather than having to dynamically account for the size of the y-axis text? cannot solve this by just making an excessively large padding by default (charts should be compact as well where possible)

@gmuralidharreddy
Copy link
Collaborator

@diehbria There is an open issue(#9265) and In-review CR(19534) in the echarts. So this issue may be fixed once their CR gets merged. I linked the echarts open issue link in code under TODO comments. And also there is no way from echarts to put ylabel at the left of the canvas. If we provide a dynamic gap then yLabel will be completely undergoing to the left border and affecting the chart and legend width calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint
Projects
None yet
Development

No branches or pull requests

2 participants