Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Toolbar] The toolbar does not follow the established design pattern #2510

Closed
jmbuss opened this issue Jan 25, 2024 · 0 comments
Labels
Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint

Comments

@jmbuss
Copy link
Contributor

jmbuss commented Jan 25, 2024

Describe the bug

Standard: 4.1.2 Name, Role, Value (A)
Affected Groups: Screen Reader Users, Keyboard Users

Notes and Advice
The dashboard toolbar does not follow the established design pattern.

The dashboard toolbar has the following issues: No accessible name (fails SC 4.1.2 Name, Role, Value)

Recommendation
Provide an accessible name for the toolbar container using aria-labelledby (if there already is a visible heading or label), or aria-label (if there is no visible label).
If there is more than one toolbar on the page, use aria-label to give each a unique accessible name.

  1. We should have a container which labels the widgets toolbar
  2. We should have a container which labels the dashboard actions (save / preview)
  3. We should have a section which labels the dashboard query configuration (asset model select view mode only / viewport picker)

Acceptance Criteria
The above violation is mitigated

@jmbuss jmbuss added bug Something isn't working Assigned to HM Work that is being assisted on by HM Current sprint labels Jan 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Jan 30, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 1, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 1, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 7, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 7, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint
Projects
None yet
Development

No branches or pull requests

2 participants