Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] making the decimal place value too large crashes dashboard #2567

Closed
1 task
diehbria opened this issue Feb 9, 2024 · 3 comments
Closed
1 task
Labels
1 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint

Comments

@diehbria
Copy link
Contributor

diehbria commented Feb 9, 2024

When the decimal place settings is set to too large of a number, the dashboard crashes:


RangeError: precision 123 out of range 
round number.js:20

dec

acceptance criteria

@diehbria diehbria added bug Something isn't working Assigned to HM Work that is being assisted on by HM Current sprint 1 pts labels Feb 9, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 15, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 15, 2024
@Kausar-HM
Copy link
Contributor

Hi @nadeswal

In this ticket we have to add validation to 'Decimal places' input, so we added the same in way it works for other fields:
image

Currently the 'Decimal places' label is to the left of the input, in the config panel all other fields have the label at top, so should we move 'Decimal places' to the top as well?

image

@nadeswal
Copy link

Here is the screenshot that you can use to replicate the design -
Screenshot 2024-02-15 at 2 32 59 PM

Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 16, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 16, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 16, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 19, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 19, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 19, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 19, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 19, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 20, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 22, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 22, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 22, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 22, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 23, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 23, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 23, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 26, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 27, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 27, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Feb 27, 2024
@jmbuss jmbuss closed this as completed Mar 18, 2024
@jmbuss jmbuss reopened this Mar 18, 2024
@jmbuss
Copy link
Contributor

jmbuss commented Mar 21, 2024

This is what the team discussed and agreed on - We will keep the decimal places as it is in it's own separate section but modify the section name to "Format data" instead of decimal places. Please refer to the screenshot below -

Screenshot 2024-03-20 at 2 20 08 PM

Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 pts Assigned to HM Work that is being assisted on by HM bug Something isn't working Current sprint
Projects
None yet
Development

No branches or pull requests

4 participants