fix(composer): Fix e.removeFromParent and camera focus #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumanity
previously approved these changes
Nov 10, 2022
|
This pull request introduces 2 alerts and fixes 1 when merging 921490f7f0e2e20664863f3379a6a0aed1220a17 into 2f51263 - view on LGTM.com new alerts:
fixed alerts:
|
jwills-jdubs
force-pushed
the
fix/refactor-camera-helper
branch
from
921490f
to
fef7310
Compare
|
This pull request fixes 1 alert when merging fef7310 into 2f51263 - view on LGTM.com fixed alerts:
|
mumanity
approved these changes
Nov 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The e.removeFromParent issue seems to be unavoidable so we needed to change what getSafeBoundingBox provides and just avoid having the helpers as children of the root node in general. This reverts to original implementations and uses the recently updated useEditorHelper
Legal
This project is available under the Apache 2.0 License.