fix(composer): Fix for useEffect error #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheilaXu
reviewed
Nov 16, 2022
...ages/scene-composer/src/components/panels/SceneHierarchyPanel/SceneHierarchyDataProvider.tsx
Outdated
Show resolved
Hide resolved
mumanity
force-pushed
the
useEffect-drop-error
branch
2 times, most recently
from
e35e553
to
afd3d58
Compare
|
This pull request introduces 2 alerts when merging afd3d58be8f85e4e1f4be6bdd2266c449cb321b0 into ca01c40 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
mumanity
force-pushed
the
useEffect-drop-error
branch
2 times, most recently
from
907bcc0
to
ffcf65d
Compare
mumanity
force-pushed
the
useEffect-drop-error
branch
from
ffcf65d
to
7e46795
Compare
sheilaXu
approved these changes
Nov 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix to unsubscribe in
useEffectthat was triggering error on drag/drop. Includes fix for type safety inmovefunction.Legal
This project is available under the Apache 2.0 License.