Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move data quality widget on gauge to be closer to value #2913

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

dpportet
Copy link
Contributor

Overview

  • Change the gauge css so its rendered from the bottom 20% of the widget
  • I looking at echarts gauge configuration to add a rich text label to make data quality party of the echarts settings, but I wasn't able to figure it out and from testing this css change it seems like it will be sufficient. I would like feedback on if this could go wrong though. The problem with this approach is we don't guarantee the data quality won't overlap with the value, but with our current default it does work.

Verifying Changes

Before Change

Screenshot 2024-07-10 at 4 52 45 PM

After Change

Screenshot 2024-07-10 at 4 48 47 PM

Legal

This project is available under the Apache 2.0 License.

@dpportet dpportet merged commit 19a7fca into rc Jul 11, 2024
20 checks passed
@dpportet dpportet deleted the gauge-quality-spacing-fix branch July 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants