Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): Correctly ignore private properties from ctor #531

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jun 12, 2019

When declared as part of a constructor argument declaration, private
properties would not be ignored as such, which could cause spurious JSII
errors, and made private APIs visible to other languages.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller RomainMuller requested a review from a team as a code owner June 12, 2019 09:13
Whend eclared as part of a constructor argument declaration, private
properties would not be ignored as such, which could cause spurious JSII
errors, and made private APIs visible to other languages.
@RomainMuller RomainMuller force-pushed the rmuller/ignore-private-ctor-properties branch from f54816b to a823135 Compare June 12, 2019 09:45
@RomainMuller RomainMuller merged commit e804cab into master Jun 12, 2019
@RomainMuller RomainMuller deleted the rmuller/ignore-private-ctor-properties branch June 12, 2019 11:47
RomainMuller added a commit that referenced this pull request Jun 18, 2019
* **jsii:** Correctly handle singleton enums ([#535](#535)) ([01aed03](01aed03)), closes [#231](#231)
* **jsii:** Correctly ignore private properties from ctor ([#531](#531)) ([e804cab](e804cab))
RomainMuller added a commit that referenced this pull request Jun 19, 2019
* **jsii:** Correctly handle singleton enums ([#535](#535)) ([01aed03](01aed03)), closes [#231](#231)
* **jsii:** Correctly ignore private properties from ctor ([#531](#531)) ([e804cab](e804cab))
RomainMuller added a commit that referenced this pull request Jun 19, 2019
* **jsii-reflect:** Expose Assembly metadata field ([#542](#542)) ([9b35e98](9b35e98))
* **jsii:** Correctly handle singleton enums ([#535](#535)) ([01aed03](01aed03)), closes [#231](#231)
* **jsii:** Correctly ignore private properties from ctor ([#531](#531)) ([e804cab](e804cab))
@RomainMuller RomainMuller mentioned this pull request Jun 19, 2019
RomainMuller added a commit that referenced this pull request Jun 19, 2019
* **jsii-reflect:** Expose Assembly metadata field ([#542](#542)) ([9b35e98](9b35e98))
* **jsii:** Correctly handle singleton enums ([#535](#535)) ([01aed03](01aed03)), closes [#231](#231)
* **jsii:** Correctly ignore private properties from ctor ([#531](#531)) ([e804cab](e804cab))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants