Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor updates for IAM CDK stack #97

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

LightSeekerSC
Copy link
Contributor

@LightSeekerSC LightSeekerSC commented May 22, 2024

Description of changes:

  • Adds comments that identify what MLSpace service different permissions are associated with
  • Refactors to consolidate some redundant or unnecessarily distinct policy statements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lib/stacks/iam.ts Outdated Show resolved Hide resolved
@dustins dustins self-requested a review May 24, 2024 14:33
@dustins dustins self-assigned this May 24, 2024
lib/stacks/iam.ts Outdated Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Outdated Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Outdated Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Show resolved Hide resolved
lib/stacks/iam.ts Outdated Show resolved Hide resolved
@LightSeekerSC
Copy link
Contributor Author

The new desired strategy is not not create this in CDK or have managed policy customers create this manually, but rather this will be dynamically generated on the first update to the Admin app-config, which will create and attach the policy where desired.

@LightSeekerSC LightSeekerSC changed the title Adds App Deny Policy For Disabling Services At An Application Level Refactor updates for IAM CDK stack Jun 3, 2024
@LightSeekerSC LightSeekerSC merged commit 5f3c259 into main Jun 5, 2024
5 checks passed
@LightSeekerSC LightSeekerSC deleted the notebook-ac-policy branch June 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants