Add requester pays support #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjvik
force-pushed
the
arjvik/requester-pays-flag
branch
from
d8046d5
to
f094e31
Compare
|
Linking to #148, since apparently titles don't get the same treatment as comments |
dannycjones
requested changes
Mar 20, 2023
dannycjones
reviewed
Mar 20, 2023
|
Thanks for the style comments @dannycjones - I committed all of the changes you suggested! |
monthonk
requested changes
Mar 20, 2023
dannycjones
changed the title
dannycjones
reviewed
Mar 20, 2023
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
|
Sorry it took so long to accept those changes :) When skimming your changes, I didn't realize you were only changing the cli args struct, I figured you intended on changing the |
arjvik
force-pushed
the
arjvik/requester-pays-flag
branch
from
1c272c8
to
23ded9d
Compare
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arjvik
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
|
Otherwise, this should be ready to merge? @monthonk @dannycjones |
monthonk
reviewed
Mar 24, 2023
Signed-off-by: Arjun Vikram <arjvik@gmail.com>
Co-authored-by: Daniel Carl Jones <danny@danielcarl.info> Signed-off-by: Arjun Vikram <arjvik@gmail.com>
Co-authored-by: Daniel Carl Jones <danny@danielcarl.info> Signed-off-by: Arjun Vikram <arjvik@gmail.com>
Co-authored-by: Daniel Carl Jones <danny@danielcarl.info> Signed-off-by: Arjun Vikram <arjvik@gmail.com>
Co-authored-by: monthonk <monthonk@amazon.co.uk> Signed-off-by: Arjun Vikram <arjvik@gmail.com>
arjvik
force-pushed
the
arjvik/requester-pays-flag
branch
from
23ded9d
to
4e3ae24
Compare
arjvik
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arjvik
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arjvik
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
|
Rebase complete! @monthonk |
dannycjones
approved these changes
Mar 24, 2023
|
Merged - thanks for the contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).