Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow RStudio EC2 to initialize #821

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
SSM params are created after RStudio EC2 is fully initialized (takes 60-90 seconds).

Description of changes:
Adding a wait time of 60-90 seconds in RStudio integration test.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #821 (12b9874) into develop (eb879fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #821   +/-   ##
========================================
  Coverage    50.91%   50.91%           
========================================
  Files          286      286           
  Lines        15931    15931           
  Branches      2485     2485           
========================================
  Hits          8111     8111           
  Misses        6863     6863           
  Partials       957      957           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb879fe...12b9874. Read the comment docs.

Copy link
Contributor

@maghirardelli maghirardelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanketD92 SanketD92 merged commit 5a3590a into develop Nov 19, 2021
@SanketD92 SanketD92 deleted the fix-integ-tests-rstudio branch November 19, 2021 17:37
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants