Fix developer guide URL #1262
Merged
Fix developer guide URL #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!! |
|
it's not critical, but if you update |
The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: awslabs/aws-sdk-rust#325 Signed-off-by: bin liu <liubin0329@gmail.com>
The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: awslabs/aws-sdk-rust#325 Signed-off-by: bin liu <liubin0329@gmail.com>
Signed-off-by: bin liu <liubin0329@gmail.com>
liubin
force-pushed
the
fix-developer-guide-url
branch
from
0bd4eef
to
c9e7db6
Compare
|
@rcoh Thank you, I rebased the main branch and updated the changelog, helping the format is correct. |
Velfi
approved these changes
Mar 18, 2022
Also link in aws-sdk-rust
|
released in v0.10.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Guide link in crate.io, for example, https://crates.io/crates/aws-sdk-s3, is pointing at an old page that has been deleted.
Description
Fix it by using the new link https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesThough I have updated the generated README.md, it's only a typo fix, should I update CHANGELOG too?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.