Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove benchmarker CSV input in favor of JSON #946

Open
Kern-- opened this issue Nov 15, 2023 · 0 comments
Open

[FEATURE] Remove benchmarker CSV input in favor of JSON #946

Kern-- opened this issue Nov 15, 2023 · 0 comments
Labels
feature New feature or request

Comments

@Kern--
Copy link
Contributor

Kern-- commented Nov 15, 2023

Description

#908 added support for specifying bechmarks in a JSON file instead of CSV. #938 Adds additional, image-specific options such as GPU support and mounts, but these are only available via the JSON configuration.

Describe the solution you'd like

Since the JSON option is easier to read and more featureful, we should remove CSV as an option and always expect the benchmark file to be JSON.

Describe any alternative solutions/features you've considered

We could add support for optional parameters to CSV (e.g. by having specific key/value pairs at the end of the options, having a field that has key=value pairs that we parse, etc).

This seems like a bad way to go because it would take more effort and parsing to reimplement features we get for free with JSON.

Any additional context or information about the feature request

No response

@Kern-- Kern-- added the feature New feature or request label Nov 15, 2023
haddscot added a commit to haddscot/soci-snapshotter that referenced this issue May 2, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
haddscot added a commit to haddscot/soci-snapshotter that referenced this issue May 2, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
haddscot added a commit to haddscot/soci-snapshotter that referenced this issue May 2, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
haddscot added a commit to haddscot/soci-snapshotter that referenced this issue May 3, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
haddscot added a commit to haddscot/soci-snapshotter that referenced this issue May 3, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
haddscot added a commit that referenced this issue May 7, 2024
Signed-off-by: Scott Haddlesey <haddscot@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant