chore: bump d3-color to 3.1.0, add postinstall hook to fix export path #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpopv
changed the title
mpopv
requested review from
NorbertNader,
tracy-french,
boweihan and
tjuranek
tjuranek
approved these changes
Oct 19, 2022
mpopv
added a commit
to mpopv/synchro-charts
that referenced
this pull request
Oct 21, 2022
…port path (awslabs#167)" This reverts commit f71f4c2.
mpopv
added a commit
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
d3-color 1.x is affected by a CVE. It is patched only in 3.1.0 and the maintainer refuses to backport the fix, so we need to upgrade.
d3-color is a dependency of several of our dependencies that specify 1.x, so we need to force resolution to 3.1.0 in package.json. This is fine because 2 and 3 merely drop support for old environments that we already disallow and do not introduce any other relevant breaking changes.
The only caveat is that newer versions switch to using the ESM source code as the package default export and expose the UMD-bundled version with the package.json
"exports"property, but this property is only recognized in yarn v2 and we need to use the UMD version. A quick fix to make the package compatible with yarn v1 is to add a postinstall hook that rewrites the"main"export path to the UMD"exports"path, which I've done here.Tests
See below
Legal
This project is available under the Apache 2.0 License.