fix: switch to fork of d3-color 1.4.x with backtracking fix from 3.1.0 applied #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpopv
requested review from
NorbertNader,
sheilaXu,
tjuranek,
chejimmy,
dpportet,
tracy-french and
diehbria
diehbria
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements a better version of the fix from #167. The maintainer of the package with the issue will not backport the fix to 1.x and recommends forking the package, and other major projects are discussing forking the package as well.
Here I have forked the package, cherry-picked the fix onto 1.4.x, and published as a new package at 1.4.2. Then, we resolve
d3-colorto that package with yarn'sresolutionsfeature (the second bullet point there describes our situation exactly).Legal
This project is available under the Apache 2.0 License.