Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP not robust to NaN metric #778

Closed
amueller opened this issue Oct 24, 2023 · 2 comments · Fixed by #788
Closed

GP not robust to NaN metric #778

amueller opened this issue Oct 24, 2023 · 2 comments · Fixed by #788
Assignees
Labels

Comments

@amueller
Copy link

I'm running MOBSTER with default parameters, and my model (for whatever reason) decided to produce np.inf, which took down the tuning process.
In particular, in transform_state_to_data, the normalization makes all the targets be NaN. One option would be to exclude inf from the normalization, but then probably the GP chokes. Setting inf to the largest observed value might make sense? Another option would be excluding the sample.
Any thoughts?

@geoalgo
Copy link
Collaborator

geoalgo commented Oct 26, 2023

Hi Andreas, thanks for flagging this it seems like a good suggestion, @mseeger is the main author of this code and may be able to help you.

@mseeger
Copy link
Collaborator

mseeger commented Nov 8, 2023

Closed with #788

@mseeger mseeger closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants